[PATCH] D30642: [ConstantFold] Fix defect in constant folding computation for GEP

Daniel Berlin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 8 07:30:33 PST 2017


dberlin accepted this revision.
dberlin added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D30642#695419, @javed.absar wrote:

> Hi Daniel:
>
> Agree with you that the ConstantFolding algorithm seems to need improvement. I will try to improve it and send you a new patch. 
>  But I also think this defect fix  need not be gated on it.


Sorry, thought i already accepted this.
I was just responding to your comment that it only does things once :)


https://reviews.llvm.org/D30642





More information about the llvm-commits mailing list