[PATCH] D30724: Dont emit Mapping symbols for Non allocatable sections.

Tim Northover via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 8 06:47:08 PST 2017


t.p.northover added a comment.

> Ah ok. Thanks for the info. If the input is 'C', the extent to which a non allocatable section that can contain data and code mixed is really a corner case, unless the author does inline assembly ?

Yep, and weird inline assembly at that. But we're writing an assembler not just a compiler so we should deal with it properly.

I'm pretty strongly against a hack like using "allocate" here: we're already in conformance with the ABI so the only purpose could be working around broken tools elsewhere and any improvement we make would be QoI. So we should actually implement it properly if we're going to.

> Is there a record of that information that can be queried about a section in the current infrastructure ?

The information is only known at the end of the section (after the symbols have been emitted in the current scheme). Unfortunately I haven't come up with a good way of delaying it yet, I'll see if I can think a bit more about it.


Repository:
  rL LLVM

https://reviews.llvm.org/D30724





More information about the llvm-commits mailing list