[llvm] r297260 - [Support] Remove unit test for fs::is_local

Jonas Hahnfeld via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 8 00:36:22 PST 2017


Author: hahnfeld
Date: Wed Mar  8 02:36:21 2017
New Revision: 297260

URL: http://llvm.org/viewvc/llvm-project?rev=297260&view=rev
Log:
[Support] Remove unit test for fs::is_local

rL295768 introduced this test that fails if LLVM is built and tested on
an NFS share. Delete the test as discussed on the corresponing commit
thread. The only feasible solution would have been to introduce
environment variables and to en/disable the test conditionally.

Modified:
    llvm/trunk/unittests/Support/Path.cpp

Modified: llvm/trunk/unittests/Support/Path.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/Support/Path.cpp?rev=297260&r1=297259&r2=297260&view=diff
==============================================================================
--- llvm/trunk/unittests/Support/Path.cpp (original)
+++ llvm/trunk/unittests/Support/Path.cpp Wed Mar  8 02:36:21 2017
@@ -444,31 +444,6 @@ protected:
   }
 
   void TearDown() override { ASSERT_NO_ERROR(fs::remove(TestDirectory.str())); }
-
-  SmallVector<Triple::ArchType, 4> UnsupportedArchs;
-  SmallVector<Triple::OSType, 4> UnsupportedOSs;
-  SmallVector<Triple::EnvironmentType, 1> UnsupportedEnvironments;
-
-  bool isUnsupportedOSOrEnvironment() {
-    Triple Host(Triple::normalize(sys::getProcessTriple()));
-
-    if (find(UnsupportedEnvironments, Host.getEnvironment()) !=
-        UnsupportedEnvironments.end())
-      return true;
-
-    if (is_contained(UnsupportedOSs, Host.getOS()))
-      return true;
-
-    if (is_contained(UnsupportedArchs, Host.getArch()))
-      return true;
-
-    return false;
-  }
-
-  FileSystemTest() {
-    UnsupportedArchs.push_back(Triple::mips);
-    UnsupportedArchs.push_back(Triple::mipsel);
-  }
 };
 
 TEST_F(FileSystemTest, Unique) {
@@ -1191,36 +1166,6 @@ TEST_F(FileSystemTest, OpenFileForRead)
   ::close(FileDescriptor);
 }
 
-#define CHECK_UNSUPPORTED() \
-  do { \
-    if (isUnsupportedOSOrEnvironment()) \
-      return; \
-  } while (0); \
-
-TEST_F(FileSystemTest, is_local) {
-  CHECK_UNSUPPORTED();
-
-  SmallString<128> CurrentPath;
-  ASSERT_NO_ERROR(fs::current_path(CurrentPath));
-
-  bool Result;
-  ASSERT_NO_ERROR(fs::is_local(CurrentPath, Result));
-  EXPECT_TRUE(Result);
-  EXPECT_TRUE(fs::is_local(CurrentPath));
-
-  int FD;
-  SmallString<64> TempPath;
-  ASSERT_NO_ERROR(fs::createTemporaryFile("prefix", "temp", FD, TempPath));
-  FileRemover Cleanup(TempPath);
-
-  // Make sure it exists.
-  ASSERT_TRUE(sys::fs::exists(Twine(TempPath)));
-
-  ASSERT_NO_ERROR(fs::is_local(FD, Result));
-  EXPECT_TRUE(Result);
-  EXPECT_TRUE(fs::is_local(FD));
-}
-
 TEST_F(FileSystemTest, set_current_path) {
   SmallString<128> path;
 




More information about the llvm-commits mailing list