[PATCH] D28759: [ExecutionDepsFix] Improve clearance calculation for loops

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 7 22:49:01 PST 2017


mehdi_amini added inline comments.


================
Comment at: llvm/trunk/lib/CodeGen/ExecutionDepsFix.cpp:837
+        processBasicBlock(Succ, false);
+        updateSuccessors(Succ, false);
+      }
----------------
mehdi_amini wrote:
> What is the limit on the depth of the stack?
> We're seeing a crash because of stack explosion here, so I fear it can grow with the CFG (which wouldn't seem reasonable to me). Can you comment on this?
Note: I haven't spent time figuring out what `ExeDepsFix` is doing, don't assume I have any context. The crash we're tracking is a ThinLTO bootstrap failure, we're still working on the exact reproducer.


Repository:
  rL LLVM

https://reviews.llvm.org/D28759





More information about the llvm-commits mailing list