[PATCH] D30725: [FileCheck] Added [[@CLEAR:regex]] as a way to clear variables.

Justin Lebar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 7 16:50:15 PST 2017


jlebar added a comment.

> It definitely does not now, I think it would be less burdensome than having to list every used variable (which is just another place you can make a typo) to clear it

Yeah, but cleaning that up globally in all our tests sounds like a recipe for disaster.  And I'm sure we'll also find some tests where we really *do* want to keep regexps alive across CHECK-LABELS.

I suppose we could have a filecheck mode that behaves as you describe, but that also sounds worse.

Also, if you don't want to list the used variables, you can match on [[@CLEAR:.*]].


https://reviews.llvm.org/D30725





More information about the llvm-commits mailing list