[PATCH] D30710: [LV] Vectorize GEPs

Matthew Simpson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 7 14:26:20 PST 2017


mssimpso updated this revision to Diff 90940.
mssimpso added a comment.

Re-implemented the widening, as previously mentioned.

- Removed the Legal->isUniform() case. Now, I just let the IRBuilder return a scalar GEP if all the operands are loop-invariant. If the result is scalar, I do the broadcast.
- The above change exposes a likely bug in fixFirstOrderRecurrences, so I've fixed that as well. The IRBuilder constant-folded the GEP in first-order-recurrences.ll away. The problematic code assumes that an instruction in the old loop will map to an instruction in the new loop. The is probably not a safe assumption in general.


https://reviews.llvm.org/D30710

Files:
  lib/Transforms/Vectorize/LoopVectorize.cpp
  test/Transforms/LoopVectorize/AArch64/first-order-recurrence.ll
  test/Transforms/LoopVectorize/X86/consecutive-ptr-uniforms.ll
  test/Transforms/LoopVectorize/X86/scatter_crash.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D30710.90940.patch
Type: text/x-patch
Size: 28602 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170307/74f81f57/attachment.bin>


More information about the llvm-commits mailing list