[PATCH] D30679: llvm-objdump: handle line numbers and source options for amdgpu objects

Zhuravlyov, Konstantin via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 7 14:02:50 PST 2017


That looks good to me. Thanks, and sorry about that.

________________________________
From: Zachary Turner <zturner at google.com>
Sent: Tuesday, March 7, 2017 4:59:17 PM
To: reviews+D30679+public+115d2c040c88ea33 at reviews.llvm.org; Konstantin Zhuravlyov via Phabricator; Zhuravlyov, Konstantin; Arsenault, Matthew; Liu, Yaxun (Sam)
Cc: Ding, Wei; llvm-commits at lists.llvm.org; tpr.llvm at botech.co.uk; Stuttard, David; Tye, Tony
Subject: Re: [PATCH] D30679: llvm-objdump: handle line numbers and source options for amdgpu objects

This test is broken on Windows.  Please take a look at this patch and see if it looks like an appropriate fix.

In general this is a standard practice for tests where pathnames are concerned, but in this case I just want to make sure the value of the path prior to the source file name is not strictly important.



On Tue, Mar 7, 2017 at 12:29 PM Konstantin Zhuravlyov via Phabricator via llvm-commits <llvm-commits at lists.llvm.org<mailto:llvm-commits at lists.llvm.org>> wrote:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297193: llvm-objdump: handle line numbers and source options for amdgpu objects (authored by kzhuravl).

Changed prior to commit:
  https://reviews.llvm.org/D30679?vs=90798&id=90911#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D30679

Files:
  llvm/trunk/test/tools/llvm-objdump/AMDGPU/Inputs/source-lines.cl<http://source-lines.cl>
  llvm/trunk/test/tools/llvm-objdump/AMDGPU/lit.local.cfg
  llvm/trunk/test/tools/llvm-objdump/AMDGPU/source-lines.ll
  llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp

_______________________________________________
llvm-commits mailing list
llvm-commits at lists.llvm.org<mailto:llvm-commits at lists.llvm.org>
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170307/bd11431a/attachment.html>


More information about the llvm-commits mailing list