[PATCH] D30047: [GlobalISel] Split LowLevelType to a fundamental type in libSupport.

[Daniel Sanders via Phabricator via llvm-commits]

dsanders added a comment.

In https://reviews.llvm.org/D30047#690852, @ab wrote:

> Ah, you're right, I completely forgot about the MVT ctor.  Yeah, it's probably better to add a getLLTForMVT() in the CodeGen header.


I've ended up going with the modulemap approach since TableGen's MVTToLLT() should eventually use that constructor.

In https://reviews.llvm.org/D30047#690854, @ab wrote:

> By the way, I think you kept the commit message of the original patch in r296474.  It's somewhat confusing;  I don't even remember what it meant ;)


MVTToLLT() used to convert MVT's into strings containing calls to the LLT constructor. It now converts MVT's into LLTCodeGen objects which know how to build that string from an LLT and also allows tablegen to inspect the LLT.


https://reviews.llvm.org/D30047