[PATCH] D26718: [llvm] Iterate SmallPtrSet in reverse order to uncover non-determinism in codegen

[Daniel Berlin via llvm-commits]

So, this change breaks smallptrset's find function when it is on.

Trivial test case:
  SmallPtrSet<int *, 8> IntSet;
  int A;
  int *B = &A;
  EXPECT_FALSE(IntSet.find(B) == IntSet.end());

Because you've made the end iterator point somewhere else, this will no
longer work.

Please fix.


On Wed, Feb 8, 2017 at 3:38 PM, Craig Topper via Phabricator via
llvm-commits <llvm-commits at lists.llvm.org> wrote:

> craig.topper added a comment.
>
> I know this was turned in a while ago. But should the command line option
> have a description or be marked hidden or both. I believe it shows up in
> -help on a debug build, but has no description.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D26718
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170307/b6b6ddf7/attachment.html>