[polly] r297158 - [tests] Make sure tests do not end in 'unreachable' - Part III

Tobias Grosser via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 7 08:28:53 PST 2017


Author: grosser
Date: Tue Mar  7 10:28:53 2017
New Revision: 297158

URL: http://llvm.org/viewvc/llvm-project?rev=297158&view=rev
Log:
[tests] Make sure tests do not end in 'unreachable' - Part III

There is no point in optimizing unreachable code, hence our test cases should
always return.

This commit is part of a series that makes Polly more robust on the presence of
unreachables.

Modified:
    polly/trunk/test/Isl/CodeGen/invariant_load_complex_condition.ll
    polly/trunk/test/Isl/CodeGen/invariant_load_different_sized_types.ll
    polly/trunk/test/Isl/CodeGen/ptrtoint_as_parameter.ll
    polly/trunk/test/ScopInfo/invariant_load_distinct_parameter_valuations.ll

Modified: polly/trunk/test/Isl/CodeGen/invariant_load_complex_condition.ll
URL: http://llvm.org/viewvc/llvm-project/polly/trunk/test/Isl/CodeGen/invariant_load_complex_condition.ll?rev=297158&r1=297157&r2=297158&view=diff
==============================================================================
--- polly/trunk/test/Isl/CodeGen/invariant_load_complex_condition.ll (original)
+++ polly/trunk/test/Isl/CodeGen/invariant_load_complex_condition.ll Tue Mar  7 10:28:53 2017
@@ -63,8 +63,8 @@ land.end:
   br i1 %5, label %for.cond104.preheader, label %for.cond34.preheader
 
 for.cond34.preheader:                             ; preds = %land.end
-  unreachable
+  ret void
 
 for.cond104.preheader:                            ; preds = %land.end
-  unreachable
+  ret void
 }

Modified: polly/trunk/test/Isl/CodeGen/invariant_load_different_sized_types.ll
URL: http://llvm.org/viewvc/llvm-project/polly/trunk/test/Isl/CodeGen/invariant_load_different_sized_types.ll?rev=297158&r1=297157&r2=297158&view=diff
==============================================================================
--- polly/trunk/test/Isl/CodeGen/invariant_load_different_sized_types.ll (original)
+++ polly/trunk/test/Isl/CodeGen/invariant_load_different_sized_types.ll Tue Mar  7 10:28:53 2017
@@ -35,10 +35,10 @@ bb10:
   br i1 %tmp11, label %bb13, label %bb12
 
 bb12:                                             ; preds = %bb10
-  unreachable
+  ret void
 
 bb13:                                             ; preds = %bb10
-  unreachable
+  ret void
 }
 
 attributes #0 = { nounwind uwtable "disable-tail-calls"="false" "less-precise-fpmad"="false" "no-frame-pointer-elim"="false" "no-infs-fp-math"="false" "no-nans-fp-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+fxsr,+mmx,+sse,+sse2" "unsafe-fp-math"="false" "use-soft-float"="false" }

Modified: polly/trunk/test/Isl/CodeGen/ptrtoint_as_parameter.ll
URL: http://llvm.org/viewvc/llvm-project/polly/trunk/test/Isl/CodeGen/ptrtoint_as_parameter.ll?rev=297158&r1=297157&r2=297158&view=diff
==============================================================================
--- polly/trunk/test/Isl/CodeGen/ptrtoint_as_parameter.ll (original)
+++ polly/trunk/test/Isl/CodeGen/ptrtoint_as_parameter.ll Tue Mar  7 10:28:53 2017
@@ -19,7 +19,7 @@ while.cond:
   br i1 undef, label %if.then260, label %while.body210
 
 while.body210:                                    ; preds = %while.cond
-  unreachable
+  ret void
 
 if.then260:                                       ; preds = %while.cond
   %p.4 = getelementptr inbounds i8, i8* null, i64 1

Modified: polly/trunk/test/ScopInfo/invariant_load_distinct_parameter_valuations.ll
URL: http://llvm.org/viewvc/llvm-project/polly/trunk/test/ScopInfo/invariant_load_distinct_parameter_valuations.ll?rev=297158&r1=297157&r2=297158&view=diff
==============================================================================
--- polly/trunk/test/ScopInfo/invariant_load_distinct_parameter_valuations.ll (original)
+++ polly/trunk/test/ScopInfo/invariant_load_distinct_parameter_valuations.ll Tue Mar  7 10:28:53 2017
@@ -107,7 +107,7 @@ bb32:
   br i1 %tmp35, label %bb37, label %bb36
 
 bb36:                                             ; preds = %bb32
-  unreachable
+  ret void
 
 bb37:                                             ; preds = %bb32
   ret void




More information about the llvm-commits mailing list