[polly] r297150 - [tests] Make sure tests do not end in 'unreachable' - Part II

Tobias Grosser via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 7 07:23:30 PST 2017


Author: grosser
Date: Tue Mar  7 09:23:30 2017
New Revision: 297150

URL: http://llvm.org/viewvc/llvm-project?rev=297150&view=rev
Log:
[tests] Make sure tests do not end in 'unreachable' - Part II

There is no point in optimizing unreachable code, hence our test cases should
always return.

This commit is part of a series that makes Polly more robust on the presence of
unreachables.

Modified:
    polly/trunk/test/Isl/CodeGen/multiple-types-invariant-load.ll
    polly/trunk/test/Isl/CodeGen/non-affine-phi-node-expansion.ll
    polly/trunk/test/Isl/CodeGen/out-of-scop-phi-node-use.ll
    polly/trunk/test/Isl/CodeGen/pr25241.ll
    polly/trunk/test/Isl/CodeGen/scop_expander_segfault.ll
    polly/trunk/test/ScopInfo/aliasing_with_non_affine_access.ll
    polly/trunk/test/ScopInfo/branch-references-loop-scev-with-unknown-iterations-2.ll
    polly/trunk/test/ScopInfo/branch-references-loop-scev-with-unknown-iterations-3.ll
    polly/trunk/test/ScopInfo/branch-references-loop-scev-with-unknown-iterations.ll
    polly/trunk/test/ScopInfo/extract_constant_factor_introduces_new_parameter.ll

Modified: polly/trunk/test/Isl/CodeGen/multiple-types-invariant-load.ll
URL: http://llvm.org/viewvc/llvm-project/polly/trunk/test/Isl/CodeGen/multiple-types-invariant-load.ll?rev=297150&r1=297149&r2=297150&view=diff
==============================================================================
--- polly/trunk/test/Isl/CodeGen/multiple-types-invariant-load.ll (original)
+++ polly/trunk/test/Isl/CodeGen/multiple-types-invariant-load.ll Tue Mar  7 09:23:30 2017
@@ -31,6 +31,6 @@ bb11:
 
 bb12:
   %tmp13 = phi float [ undef, %bb11 ], [ 1.000000e+00, %bb4 ]
-  unreachable
+  ret void
 }
 

Modified: polly/trunk/test/Isl/CodeGen/non-affine-phi-node-expansion.ll
URL: http://llvm.org/viewvc/llvm-project/polly/trunk/test/Isl/CodeGen/non-affine-phi-node-expansion.ll?rev=297150&r1=297149&r2=297150&view=diff
==============================================================================
--- polly/trunk/test/Isl/CodeGen/non-affine-phi-node-expansion.ll (original)
+++ polly/trunk/test/Isl/CodeGen/non-affine-phi-node-expansion.ll Tue Mar  7 09:23:30 2017
@@ -53,5 +53,5 @@ bb14:
   br label %bb15
 
 bb15:                                             ; preds = %bb14
-  unreachable
+  ret void
 }

Modified: polly/trunk/test/Isl/CodeGen/out-of-scop-phi-node-use.ll
URL: http://llvm.org/viewvc/llvm-project/polly/trunk/test/Isl/CodeGen/out-of-scop-phi-node-use.ll?rev=297150&r1=297149&r2=297150&view=diff
==============================================================================
--- polly/trunk/test/Isl/CodeGen/out-of-scop-phi-node-use.ll (original)
+++ polly/trunk/test/Isl/CodeGen/out-of-scop-phi-node-use.ll Tue Mar  7 09:23:30 2017
@@ -26,7 +26,7 @@ for.cond:
   ]
 
 _LZMA_C_RDBD:                                     ; preds = %for.cond
-  unreachable
+  ret void
 
 sw.bb.956:                                        ; preds = %for.cond
   %_s.sroa.294.0.ph519.lcssa2388 = phi i32 [ undef, %for.cond ]
@@ -42,13 +42,13 @@ if.else.969:
 
 for.cond.981:                                     ; preds = %if.else.969, %if.then.960, %for.cond
   %_s.sroa.343.0.ph5161118 = phi i32 [ %_s.sroa.343.0.ph516.lcssa2357, %if.then.960 ], [ %_s.sroa.343.0.ph516.lcssa2357, %if.else.969 ], [ undef, %for.cond ]
-  unreachable
+  ret void
 
 for.cond.outer.outer.outer:                       ; preds = %entry
   br label %for.cond
 
 saveStateAndReturn:                               ; preds = %for.cond
-  unreachable
+  ret void
 
 cleanup.1072:                                     ; preds = %for.cond
   ret void

Modified: polly/trunk/test/Isl/CodeGen/pr25241.ll
URL: http://llvm.org/viewvc/llvm-project/polly/trunk/test/Isl/CodeGen/pr25241.ll?rev=297150&r1=297149&r2=297150&view=diff
==============================================================================
--- polly/trunk/test/Isl/CodeGen/pr25241.ll (original)
+++ polly/trunk/test/Isl/CodeGen/pr25241.ll Tue Mar  7 09:23:30 2017
@@ -35,10 +35,10 @@ entry:
 
 while.body.740:                                   ; preds = %if.else.864, %if.then.862
   %curr.3 = phi i32 [ %inc863, %if.then.862 ], [ undef, %if.else.864 ]
-  unreachable
+  ret void
 
 sw.bb.748:                                        ; preds = %entry
-  unreachable
+  ret void
 
 if.then.813:                                      ; preds = %entry
   %conv823903 = and i32 undef, undef

Modified: polly/trunk/test/Isl/CodeGen/scop_expander_segfault.ll
URL: http://llvm.org/viewvc/llvm-project/polly/trunk/test/Isl/CodeGen/scop_expander_segfault.ll?rev=297150&r1=297149&r2=297150&view=diff
==============================================================================
--- polly/trunk/test/Isl/CodeGen/scop_expander_segfault.ll (original)
+++ polly/trunk/test/Isl/CodeGen/scop_expander_segfault.ll Tue Mar  7 09:23:30 2017
@@ -27,5 +27,5 @@ lor.lhs.false81:
   br label %do.body172
 
 do.body172:                                       ; preds = %lor.lhs.false81
-  unreachable
+  ret void
 }

Modified: polly/trunk/test/ScopInfo/aliasing_with_non_affine_access.ll
URL: http://llvm.org/viewvc/llvm-project/polly/trunk/test/ScopInfo/aliasing_with_non_affine_access.ll?rev=297150&r1=297149&r2=297150&view=diff
==============================================================================
--- polly/trunk/test/ScopInfo/aliasing_with_non_affine_access.ll (original)
+++ polly/trunk/test/ScopInfo/aliasing_with_non_affine_access.ll Tue Mar  7 09:23:30 2017
@@ -40,7 +40,7 @@ if.then148:
   br label %if.end149
 
 if.end149:                                        ; preds = %if.then148, %for.end143
-  unreachable
+  ret void
 }
 
 define void @test2(%struct.info** %ppIdxInfo, i64 %n) {
@@ -63,7 +63,7 @@ if.then148:
   br label %if.end149
 
 if.end149:                                        ; preds = %if.then148, %for.end143
-  unreachable
+  ret void
 }
 
 define i32 @test3(i32* %x, i32 %n) {

Modified: polly/trunk/test/ScopInfo/branch-references-loop-scev-with-unknown-iterations-2.ll
URL: http://llvm.org/viewvc/llvm-project/polly/trunk/test/ScopInfo/branch-references-loop-scev-with-unknown-iterations-2.ll?rev=297150&r1=297149&r2=297150&view=diff
==============================================================================
--- polly/trunk/test/ScopInfo/branch-references-loop-scev-with-unknown-iterations-2.ll (original)
+++ polly/trunk/test/ScopInfo/branch-references-loop-scev-with-unknown-iterations-2.ll Tue Mar  7 09:23:30 2017
@@ -43,5 +43,5 @@ then:
   br label %end
 
 end:
-  unreachable
+  ret void
 }

Modified: polly/trunk/test/ScopInfo/branch-references-loop-scev-with-unknown-iterations-3.ll
URL: http://llvm.org/viewvc/llvm-project/polly/trunk/test/ScopInfo/branch-references-loop-scev-with-unknown-iterations-3.ll?rev=297150&r1=297149&r2=297150&view=diff
==============================================================================
--- polly/trunk/test/ScopInfo/branch-references-loop-scev-with-unknown-iterations-3.ll (original)
+++ polly/trunk/test/ScopInfo/branch-references-loop-scev-with-unknown-iterations-3.ll Tue Mar  7 09:23:30 2017
@@ -79,5 +79,5 @@ then:
   br label %end
 
 end:
-  unreachable
+  ret void
 }

Modified: polly/trunk/test/ScopInfo/branch-references-loop-scev-with-unknown-iterations.ll
URL: http://llvm.org/viewvc/llvm-project/polly/trunk/test/ScopInfo/branch-references-loop-scev-with-unknown-iterations.ll?rev=297150&r1=297149&r2=297150&view=diff
==============================================================================
--- polly/trunk/test/ScopInfo/branch-references-loop-scev-with-unknown-iterations.ll (original)
+++ polly/trunk/test/ScopInfo/branch-references-loop-scev-with-unknown-iterations.ll Tue Mar  7 09:23:30 2017
@@ -53,5 +53,5 @@ then:
   br label %end
 
 end:
-  unreachable
+  ret void
 }

Modified: polly/trunk/test/ScopInfo/extract_constant_factor_introduces_new_parameter.ll
URL: http://llvm.org/viewvc/llvm-project/polly/trunk/test/ScopInfo/extract_constant_factor_introduces_new_parameter.ll?rev=297150&r1=297149&r2=297150&view=diff
==============================================================================
--- polly/trunk/test/ScopInfo/extract_constant_factor_introduces_new_parameter.ll (original)
+++ polly/trunk/test/ScopInfo/extract_constant_factor_introduces_new_parameter.ll Tue Mar  7 09:23:30 2017
@@ -37,5 +37,5 @@ bb11:
   br label %bb16
 
 bb16:                                             ; preds = %bb11, %bb10
-  unreachable
+  ret void
 }




More information about the llvm-commits mailing list