[PATCH] D30612: [APInt] Add rvalue reference support to and, or, xor operations to allow their memory allocation to be reused when possible

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Looks reasonable - I would (vaguely/generally - haven't thought about it very hard) wonder if the test cases could be simpler. I'd expect only one constant, maybe - (b1100 - or any other 4 bit sequence with 2 x 1s and 2 x 0s, to test the usual combination of ones and zeros on each side in each operation?). & hardcode the expected result with a literal instead of another APInt? Not sure. Anyway - if that seems like the tidiest/simplest testing for it, that's OK.


https://reviews.llvm.org/D30612