[PATCH] D30107: Make DynamicLibrary::getPermanentLibrary have a defined ordering.

Frederich Munch via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 6 14:13:57 PST 2017


marsupial added a comment.

I was asked to make the changes that grew it in size.
There doesn't seem to be an -easy- way to fix the issues at hand for a couple of reasons.
Just fixing the iteration order by using **rbegin** and **rend** is not enough, as the storage in a **set** is also a culprit.
Just fixing the Windows portion, means differing (and still broken) behavior on Unix.
The remaining broken behaviour on Unix means that the test cannot be added.

Though I do agree that this has stalled and do not know how to rectify that...


https://reviews.llvm.org/D30107





More information about the llvm-commits mailing list