[PATCH] D30576: [AArch64] Extend redundant copy elimination pass to handle CMN compares and shifted immediates.

Chad Rosier via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 6 13:24:16 PST 2017


mcrosier added a comment.

In https://reviews.llvm.org/D30576#693589, @gberry wrote:

> LGTM if you add a negative test case with a 64-bit known constant, where the high 32-bits are not equal to 0.


This is handled by test18 previously committed in r296809.



================
Comment at: test/CodeGen/AArch64/machine-copy-remove.mir:513
 ...
 # Make sure the MOVi64imm is not removed.  In one version of this patch the
 # MOVi64imm immediate was truncated to 32 bits and incorrectly matched because
----------------
I believe this is the test case you're suggesting.


https://reviews.llvm.org/D30576





More information about the llvm-commits mailing list