[PATCH] D30357: [ObjectYAML] NFC. Refactor DWARFYAML CompileUnit dump code

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 6 11:49:10 PST 2017


aprantl added a comment.

My LGTM still stands, there's nothing left here that couldn't be fixed in a post-commit review. I found one more opportunity to simplify the code a bit inline.



================
Comment at: lib/ObjectYAML/DWARFVisitor.cpp:93
+                                          FormVal->BlockData.size()),
+                                ""));
+            break;
----------------
This chunk also looks like it could be factored out into a templated function.


https://reviews.llvm.org/D30357





More information about the llvm-commits mailing list