[PATCH] D30598: Refactor alias check from MISched into common helper. NFC.

Chad Rosier via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 6 10:10:51 PST 2017


mcrosier added a subscriber: gberry.
mcrosier added a comment.

In https://reviews.llvm.org/D30598#692161, @MatzeB wrote:

> > One thing I found kind of confusing was that I'm not sure what the rules for areMemAccessesTriviallyDisjoint are supposed to be. It looks like a lot of targets assume that the function is in SSA form (checking equality between two registers without checking whether the value of that register is modified), but we call it after register allocation. How is this supposed to work?
>
> I'm no expert here but I think the areMemAccessesTriviallyDisjoint() works because it is only used for scheduling where a change in the value of the register would inhibit reordering anyway.


Yes, I believe this is the same conclusion @gberry and I arrived at in the recent past.


Repository:
  rL LLVM

https://reviews.llvm.org/D30598





More information about the llvm-commits mailing list