[PATCH] D30648: In Thumb1, materialize a move between low registers as a `movs`, if CPSR isn't live.

Jonathan Roelofs via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 6 06:22:37 PST 2017


jroelofs added a comment.

LGTM with one small nit.



================
Comment at: test/CodeGen/Thumb/copy_thumb.ll:27
-; CHECK-NOLOLOMOV:       push  {[[TMP]]}
-; CHECK-NOLOLOMOV-NEXT:  pop {[[SRC2]]}
 ; CHECK-NOLOLOMOV-LABEL: bar
----------------
Please add a testcase for v4t and v5t that has CPSR live, so as to test the behavior in the other branch.


https://reviews.llvm.org/D30648





More information about the llvm-commits mailing list