[PATCH] D30566: [ELF] - Do not try to create .eh_frame_hdr for relocatable output.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In https://reviews.llvm.org/D30566#692868, @grimar wrote:

> In https://reviews.llvm.org/D30566#691493, @jhenderson wrote:
>
> > I think it would make sense to put the test inside the same test as the normal .eh_frame_hdr test. That way we know for certain that an .eh_frame_hdr would definitely be created if -r was not specified, and that we aren't getting a spurious pass.
>
>
> I probably would not do that. Normal .eh_frame_hdr test is a "eh-frame-hdr.s" for example, it is itself complete and large enough.
>  We already have 15 testcases named "relocatable-<something>.s" for testing relocatable output specific things. It is consistent for new test to go into that group.


Fair enough, since there's prior art for this.

Looks good from my point of view, but should probably get a LGTM from somebody with a little more familiarity with the code-base.


https://reviews.llvm.org/D30566