[PATCH] D30603: New Test-Case for Region Analysis

[Tobias Grosser via Phabricator via llvm-commits]

grosser added a comment.

Hi Nandini,

it seems your patch indeed renamed the basic block names from "0" (which means no name) to "bb0". That was precisely the effect I expected.

Now, you now unfortunately only submitted the diff between the previous and the new state of your change, instead of the diff between the current LLVM trunk and your patch. This is a common misunderstanding with phabricator. What you want to do is to rebase your patch and merge the different patches into a single one, which you then submit as new update of this patch. Could you please do this final update, such that I can then commit your patch.

Best,
Tobias


https://reviews.llvm.org/D30603