[PATCH] D30598: Refactor alias check from MISched into common helper. NFC.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 3 17:41:49 PST 2017


efriedma created this revision.
Herald added a subscriber: MatzeB.

The API seems okay as-is, but maybe it could be improved a little.  Maybe it makes sense to loosen the mayStore requirement?

One thing I found kind of confusing was that I'm not sure what the rules for areMemAccessesTriviallyDisjoint are supposed to be.  It looks like a lot of targets assume that the function is in SSA form (checking equality between two registers without checking whether the value of that register is modified), but we call it after register allocation.  How is this supposed to work?


Repository:
  rL LLVM

https://reviews.llvm.org/D30598

Files:
  include/llvm/CodeGen/MachineInstr.h
  lib/CodeGen/MachineInstr.cpp
  lib/CodeGen/ScheduleDAGInstrs.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D30598.90555.patch
Type: text/x-patch
Size: 7278 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170304/4728785e/attachment.bin>


More information about the llvm-commits mailing list