[PATCH] D30380: Teach lit to expand glob expressions

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 3 11:31:56 PST 2017


MatzeB: I have not tested, but my understanding was that on Unix systems we
aren't even using the lit shell, so none of this code would ever get run
anyway.

On Fri, Mar 3, 2017 at 11:16 AM Matthias Braun via Phabricator <
reviews at reviews.llvm.org> wrote:

> MatzeB added a comment.
>
> Have you tested these changes on a unix system yet? I think we concatenate
> all the RUN lines together into a single command on unix, so wouldn't that
> resolve the glob pattern before any of the commands that produce the
> intermediate files have even run?
>
> > I would really like the lit shell to be as much like bash as possible to
> match test writers' expectations.
>
> +1 (though we should better say posix shell instead of bash)! In any way
> shell should be a very familiar language and should really be powerful
> enough for our needs.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D30380
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170303/d59004eb/attachment.html>


More information about the llvm-commits mailing list