[PATCH] D30380: Teach lit to expand glob expressions

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: llvm/utils/lit/lit/ShCommands.py:38
 
+class GlobItem:
+    def __init__(self, pattern):
----------------
This is a nicer design than what I suggested. :)


================
Comment at: llvm/utils/lit/lit/ShUtil.py:101
+        # be re-written to work correctly without triggering this).
+        assert not (quoted_glob_char and unquoted_glob_char)
+        return GlobItem(str) if unquoted_glob_char else str
----------------
Seems like a reasonable limitation to me.


https://reviews.llvm.org/D30380