[PATCH] D30544: [lld] - Ignore non-elf files in archives with --whole-archive

[Owen Reynolds via Phabricator via llvm-commits]

gbreynoo added a comment.

Thanks for the correction grimar you are right, it is a fatal error and not a crash. However I think the change is still useful, I’ll clarify the reasons I submitted this patch below:

1. llvm-ar allows for the creation of archives with a mixture of ELF and other arbitrary files.
2. Historically our customers use archives with a mixture of ELF and other arbitrary files.
3. A fatal error does not seem appropriate when the file type can be discerned at this point and not interrupt the linking process. Could a warning be output instead if required?


https://reviews.llvm.org/D30544