[PATCH] D30521: Introduce llc/ExecuteTestCommands pass

Krzysztof Parzyszek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 3 05:40:52 PST 2017


kparzysz added a comment.

This is really nice, but I have a few questions:

- Will the testCommands be limited to functions that can take immediate values (i.e no functions taking pointers to MachineInstr or MachineBasicBlock)?
- Are users expected to be adding more functions to ExecuteTestCommands.cpp as they create new tests?



================
Comment at: test/CodeGen/AMDGPU/handlemove.mir:54
+    S_NOP 0, implicit %0
+testCommands: getMBB(0).handleMove(2,1)"
+---
----------------
Is the " at the end a typo?


Repository:
  rL LLVM

https://reviews.llvm.org/D30521





More information about the llvm-commits mailing list