[PATCH] D30542: [ARM] fpscr read/write intrinsics not aware of each other.

James Molloy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 3 01:46:05 PST 2017


jmolloy accepted this revision.
jmolloy added a comment.
This revision is now accepted and ready to land.

Hi Ranjeet,

This looks correct to me - modelling sideeffects as memory reads/writes is fairly standard. However, in your testcase you appear to be using attribute sets that aren't defined (#0, #1, #2) - does that actually compile? They should be removed nevertheless.

Otherwise LGTM.

James


https://reviews.llvm.org/D30542





More information about the llvm-commits mailing list