[PATCH] D30491: [AArch64AsmParser] cleanup/rewrite of function parseSysAlias

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 3 00:18:57 PST 2017


SjoerdMeijer added inline comments.


================
Comment at: lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:2421
     }
+    createSysAlias(TLBI->Encoding, Operands, S);
   }
----------------
rengolin wrote:
> Its a shame these are completely different namespaces. The code could have been so much simpler. :)
Thanks for reviewing! I agree and I am also not entirely happy yet as there is still a bit of code repetition going on here. But this is (almost infinitely) better than it was, and I will see if I can address this in a next cleanup. Cheers.


https://reviews.llvm.org/D30491





More information about the llvm-commits mailing list