[PATCH] D30525: [APInt] Add setLowBits/setHighBits methods to APInt.

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 2 16:31:13 PST 2017

Previous message: [PATCH] D30525: [APInt] Add setLowBits/setHighBits methods to APInt.
Next message: [PATCH] D30525: [APInt] Add setLowBits/setHighBits methods to APInt.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

hans added a comment.

In https://reviews.llvm.org/D30525#691195, @craig.topper wrote:

> I think it at least makes sense to have setLowBits/setHighBits as convenience methods. Particularly for setHighBits the caller shouldn't have to write setBits(BitWidth, BitWidth - hiBitsToSet).


Yes, agreed.


https://reviews.llvm.org/D30525

Previous message: [PATCH] D30525: [APInt] Add setLowBits/setHighBits methods to APInt.
Next message: [PATCH] D30525: [APInt] Add setLowBits/setHighBits methods to APInt.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list