[PATCH] D30525: [APInt] Add setLowBits/setHighBits methods to APInt.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 2 16:02:00 PST 2017


craig.topper added a comment.

I'm definitely going to look at moving some of setBits inline. I'm also planning to fix getBitsSet to use setBits. I might even fix setBits to support loBit > hiBit like getBitsSet supports.

I think it at least makes sense to have setLowBits/setHighBits as convenience methods. Particularly for setHighBits the caller shouldn't have to write setBits(BitWidth, BitWidth - hiBitsToSet).


https://reviews.llvm.org/D30525





More information about the llvm-commits mailing list