[PATCH] D30557: [AMDGPU] Remove getBidirectionalReasonRank

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 2 16:03:21 PST 2017


rampitec created this revision.
Herald added subscribers: tpr, dstuttard, tony-tye, yaxunl, nhaehnle, wdng, kzhuravl, arsenm.

This method inverts the Reason field of a scheduling candidate.
It does right comparison between RegCritical and RegExcess, but
everything else is broken. In fact it can prefer less strong reason
such as Weak over RegCritical because Weak > -RegCritical.

The CandReason enum is properly sorted, so just remove artificial
ranking.


Repository:
  rL LLVM

https://reviews.llvm.org/D30557

Files:
  lib/Target/AMDGPU/GCNSchedStrategy.cpp
  test/CodeGen/AMDGPU/cgp-bitfield-extract.ll
  test/CodeGen/AMDGPU/clamp.ll
  test/CodeGen/AMDGPU/ds_read2st64.ll
  test/CodeGen/AMDGPU/flat_atomics.ll
  test/CodeGen/AMDGPU/insert_vector_elt.v2i16.ll
  test/CodeGen/AMDGPU/llvm.amdgcn.cvt.pkrtz.ll
  test/CodeGen/AMDGPU/pack.v2f16.ll
  test/CodeGen/AMDGPU/pack.v2i16.ll
  test/CodeGen/AMDGPU/salu-to-valu.ll
  test/CodeGen/AMDGPU/select-fabs-fneg-extract.ll
  test/CodeGen/AMDGPU/uniform-cfg.ll
  test/CodeGen/AMDGPU/v_cndmask.ll
  test/CodeGen/AMDGPU/valu-i1.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D30557.90413.patch
Type: text/x-patch
Size: 14766 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170303/dc2114f9/attachment-0001.bin>


More information about the llvm-commits mailing list