[PATCH] D27503: [XRay] Custom event logging intrinsic

[Dean Michael Berris via Phabricator via llvm-commits]

dberris planned changes to this revision.
dberris added a comment.

Actually, while working on the compiler-rt side of things it turns out the sleds aren't quite that simple to nail down. I have some local changes and am iterating, mostly based on trying it out and hitting different roadblocks.

However, if you have feedback on the following issues, it would be most appreciated:

- Fixing up the size of the sleds in all situations. It seems the initial assumptions in the comments are different (it largely depends on which registers are being pushed in, and the encoding of the push operations will vary in x86 if the arguments are passed in following a specific ABI).
- Whether we can enforce a specific ABI for an intrinsic so that, say, we always have the first and second arguments to the trampoline be in `%rdi` and `%rsi` (as in the System V ABI).

Cheers


https://reviews.llvm.org/D27503