[PATCH] D30357: [ObjectYAML] NFC. Refactor DWARFYAML CompileUnit dump code

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 2 14:09:09 PST 2017


aprantl added inline comments.


================
Comment at: lib/ObjectYAML/DWARFVisitor.h:35
+  /// @{
+  virtual void OnStartCompileUnit(Unit &CU) {}
+  virtual void OnEndCompileUnit(Unit &CU) {}
----------------
Side note: Not sure how much work this is, but technically these should all start with lower case:

http://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly


https://reviews.llvm.org/D30357





More information about the llvm-commits mailing list