[PATCH] D30521: Introduce llc/ExecuteTestCommands pass

Kristof Beyls via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 2 03:04:10 PST 2017


kristof.beyls added inline comments.


================
Comment at: test/CodeGen/AMDGPU/handlemove.mir:1-12
+# RUN: llc -o - %s -mtriple=amdgcn -verify-machineinstrs -run-pass=execute-test-commands | FileCheck %s
+...
+name: MoveUpDef
+body: |
+  bb.0:
+    S_NOP 0
+    S_NOP 0
----------------
Without reading the source of the rest of this patch, I find it hard to guess exactly what this is testing.
Maybe before committing, also some documentation should be written on how to use this new feature?
I'm not sure where the best place would be for that documentation to live. Maybe http://llvm.org/docs/MIRLangRef.html?


Repository:
  rL LLVM

https://reviews.llvm.org/D30521





More information about the llvm-commits mailing list