[PATCH] D30510: Vulcan is now ThunderX2T99

[Renato Golin via Phabricator via llvm-commits]

rengolin added a comment.

Hi Stefan,

Normally, I'd say this needs to first add the new name, then remove the old one one release later. But since we're at the release boundary, we can announce on the 4.0 release notes that the name will change in the 5.0 release.

This means the patch cannot be backported to 4.0.

A few inline comments...

cheers,
--renato



================
Comment at: lib/Target/AArch64/AArch64.td:373
 def : ProcessorModel<"thunderxt83", ThunderXT8XModel,  [ProcThunderXT83]>;
+// Cavium ThunderX2T9X  Processors
+def : ProcessorModel<"thunderx2t99", ThunderX2T99Model, [ProcThunderX2T99]>;
----------------
Just add a comment "ex-Vulcan"


================
Comment at: unittests/Support/TargetParserTest.cpp:648
+      AArch64::AEK_CRC | AArch64::AEK_CRYPTO | AArch64::AEK_LSE |
+      AArch64::AEK_SIMD,
+      "8.1-A"));
----------------
format


Repository:
  rL LLVM

https://reviews.llvm.org/D30510