Commit 294685 broke offset initialization in MachineLocation(unsigned R, int O)

Eugene Zelenko via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 1 14:42:23 PST 2017


Hi, Frej!

Thank you for spotting problem and sorry for introducing it!

Fixed in r296697 .

Hi, Adrian!

> 2. Eugene, if this change was possible without breaking the LLVM testsuite, it looks like we have a gap in test coverage in the code that your commit changed. Could you please take a look?
>
> -- adrian

Sure, it's weird that problem was not caught by regressions. But I
think will be better to address test case request to code maintainers.

Eugene.

On Wed, Mar 1, 2017 at 3:42 AM, Frej Drejhammar <frej at sics.se> wrote:
> Hi Eugene,
>
> Your SVN commit 294685 removed the initialization of the 'Offset' field
> for register-indirect MachineLocations, probably due to a mixup between
> Offset(O) and Offset(0). The attached patch restores the functionality.
>
> Cheers,
>
> --Frej


More information about the llvm-commits mailing list