[PATCH] D30500: [ELF] - Do not treat colon(":") as separate token in script parser.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/LinkerScript.cpp:1975-1977
+bool ScriptParser::isNextLocal() {
+  return peek() == "local:" || (peek() == "local" && peek(1) == ":");
+}
----------------
Handling only "local:" is not good. You have the same issue with "global:". You want to change this to `bool consumeLabel(StringRef)` and use it as `consumeLabel("local")` or `consumeLabel("global")`. It also needs comment that this is the only part that makes the grammar LL(2).


https://reviews.llvm.org/D30500