[PATCH] D29840: test-release.sh: Remove workaround for test-suite build

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 1 02:48:42 PST 2017


rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.

Right, there are many "offences" surrounding Bash quoting, but none of them are new, so the script will blow up much earlier if any path has spaces in it, so this is not a fix for this patch.

For that reason, LGTM. Thanks!

PS: We should pass ShellCheck on that script and do a single commit to fix all potential bashisnms, later.


https://reviews.llvm.org/D29840





More information about the llvm-commits mailing list