[PATCH] D30451: [X86][AVX512] Adding new LLVM TableGen backend which generates the EVEX2VEX compressing tables.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

Should we fix the deficiencies in the current tables first so that there are no test changes?



================
Comment at: utils/TableGen/X86EVEX2VEXTablesEmitter.cpp:91
+  // Some VEX instructions were duplicated to multiple EVEX versions due the
+  // instroduction of mask variants, and thus some of the EVEX versions have
+  // different encoding than the VEX instruction. In order to maximise the
----------------
introduction*


================
Comment at: utils/TableGen/X86EVEX2VEXTablesEmitter.cpp:92
+  // instroduction of mask variants, and thus some of the EVEX versions have
+  // different encoding than the VEX instruction. In order to maximise the
+  // compression we add these entries manually.
----------------
maximize*


https://reviews.llvm.org/D30451