[PATCH] D27503: [XRay] Custom event logging intrinsic

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 28 19:59:29 PST 2017


dberris planned changes to this revision.
dberris added a comment.

Actually, now that I think about it more, it seems that we can get away with just always precisely pushing the values in the arguments (the pointer value and the size) and not worrying about the x86 calling convention -- since we in theory control what the trampoline does anyway in compiler-rt. I'm working on some local changes to reflect this. We also want to change the type of the size argument so that it reflects what 'size_t' might be for the platform.


https://reviews.llvm.org/D27503





More information about the llvm-commits mailing list