[PATCH] D30447: [SLP] Preserve IR flags for extra args.

[Michael Kuperstein via Phabricator via llvm-commits]

mkuper accepted this revision.
mkuper added a comment.
This revision is now accepted and ready to land.

LGTM with some style nits.



================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:308
+  typedef MapVector<Value *, SmallVector<Instruction *, 2>>
+      ExtraValueToDebugLocsMap;
 
----------------
Please change the name of the map to represent what it actually does.


================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:4449
+      ExternallyUsedValues[Pair.second].push_back(Pair.first);
     while (i < NumReducedVals - ReduxWidth + 1 && ReduxWidth > 2) {
       auto VL = makeArrayRef(&ReducedVals[i], ReduxWidth);
----------------
Could you add a space here?


https://reviews.llvm.org/D30447