[PATCH] D29966: [SelectionDAG] Try to recompute LiveOutInfo of PHI

[Chad Rosier via Phabricator via llvm-commits]

mcrosier added a comment.

Just a few general comments.



================
Comment at: include/llvm/CodeGen/FunctionLoweringInfo.h:187
 
+  SmallPtrSet<const PHINode *, 4> InvalidatedPHIs;
+
----------------
Please add a comment specifying what is contained in this set.


================
Comment at: include/llvm/CodeGen/FunctionLoweringInfo.h:270
+  /// which was invalidated before.
+  const LiveOutInfo *TryToRecomputePHILiveOutRegInfo(Value *V,
+                                                     unsigned BitWidth);
----------------
The function name should begin with a lower case letter and the doxygen comment shouldn't have the function name.  This differs from the style of the surrounding code, but we should make the jump to the preferred style.


================
Comment at: lib/CodeGen/SelectionDAG/FunctionLoweringInfo.cpp:413
+const FunctionLoweringInfo::LiveOutInfo *
+FunctionLoweringInfo::TryToRecomputePHILiveOutRegInfo(Value *V,
+                                                      unsigned BitWidth) {
----------------
Perhaps add a few comments describing the function and the assumptions it makes.


https://reviews.llvm.org/D29966