[PATCH] D30380: Teach lit to expand glob expressions

[Matthias Braun via Phabricator via llvm-commits]

MatzeB added a comment.

In https://reviews.llvm.org/D30380#688976, @MatzeB wrote:

> > 
> > 
> >> Other examples include where a test program can take many inputs, and you put all your input files in a single directory.  Sure you could write out each one, but this is higher maintenance and much uglier to look at when reading the test.  Every time you add or remove an input, you need to go remember to update the test.
>
> The same discussion is going for decades of whether it is fine to use glob constructs in Makefiles (or cmakefiles) to not specify every single source file. I'd say most people think it is a bad idea to use glob there.


And to give you an example of what can happen if you glob: Today if you run the unittests in llvm lit globs builddir/unittests for executables and runs everything it finds. The result is that when I removed a unittest a while back, the executable would stay on the incremental bots and they happily kept executing an old test and eventually break. This leads to stupid hacks like r261194 (short of fixing it properly and have cmake compile a definite list of unittest executables that need to be run).


https://reviews.llvm.org/D30380