[PATCH] D30380: Teach lit to expand glob expressions

[Matthias Braun via Phabricator via llvm-commits]

MatzeB added a comment.

In https://reviews.llvm.org/D30380#688937, @zturner wrote:

> In https://reviews.llvm.org/D30380#688936, @zturner wrote:
>
> > I don't think it's necessarily fair to classify these tests as poorly designed.  dynamic tools, by design, often need to do things with the file system and the tests need to verify this behavior.  LLDB (once it starts moving more towards list tests) will definitely need to be doing the same thing.  So I don't believe this to be a one-off addition.
>
>
> s/list/lit/


I still consider it bad design if you don't know what your dynamic are doing/are supposed to be doing. Anyway it's a minor thing so go ahead with this if you must, I just hope people will not start to use this too much.

As for LLDB I would expect it to be complicated enough to want/need a custom lit test plugin anyway in which it can handle all the things it requires. I haven't looked at lldb code yet, maybe it is already using one?


https://reviews.llvm.org/D30380