[PATCH] D30380: Teach lit to expand glob expressions

[Zachary Turner via Phabricator via llvm-commits]

zturner added a comment.

This might look like a single test, but this issue has come up repeatedly in compiler-rt and libfuzzer.

here is the list of all tests that have a run line matching the expression `RUN: .*\*.*`.  Note this doesn't catch all instances of using a wildcard.

  D:\src\llvm-mono\llvm\lib\Fuzzer\test\dump_coverage.test(3):RUN: xargs sancov -covered-functions LLVMFuzzer-NullDerefTest* %t_workdir/*.sancov | FileCheck %s --check-prefix=SANCOV
  D:\src\llvm-mono\llvm\lib\Fuzzer\test\merge.test(10):RUN: cp %tmp/T0/* %tmp/T1/
  D:\src\llvm-mono\llvm\lib\Fuzzer\test\merge.test(33):RUN: rm %tmp/T1/*
  D:\src\llvm-mono\llvm\lib\Fuzzer\test\merge.test(34):RUN: cp %tmp/T0/* %tmp/T1/
  D:\src\llvm-mono\llvm\lib\Fuzzer\test\merge.test(40):RUN: rm %tmp/T1/*
  D:\src\llvm-mono\llvm\lib\Fuzzer\test\merge.test(41):RUN: cp %tmp/T0/* %tmp/T1/
  D:\src\llvm-mono\llvm\lib\Fuzzer\test\merge.test(51):RUN: rm -rf  %tmp/T1/* %tmp/T2/*
  D:\src\llvm-mono\llvm\lib\Fuzzer\test\minimize_crash.test(6):RUN: rm not_minimal_crash minimized-from-* exact_minimized_path
  D:\src\llvm-mono\llvm\lib\Fuzzer\test\minimize_crash.test(8):RUN: echo -n 'abcd*xyz' > not_minimal_crash
  D:\src\llvm-mono\llvm\test\tools\llvm-cov\llvm-cov.test(11):RUN: cp %p/Inputs/test* .

I don't think it's necessarily fair to classify these tests as poorly designed.  dynamic tools, by design, often need to do things with the file system and the tests need to verify this behavior.  LLDB (once it starts moving more towards list tests) will definitely need to be doing the same thing.  So I don't believe this to be a one-off addition.


https://reviews.llvm.org/D30380