[PATCH] D30352: [JumpThread] Use AA in SimplifyPartiallyRedundantLoad()

[Renato Golin via Phabricator via llvm-commits]

rengolin added a comment.

In https://reviews.llvm.org/D30352#688862, @dberlin wrote:

> In the future, can you please analyze why this is happening?
>  This is another example of a test case that is unrelated to the pattern you are trying to optimize.  That means if this broke optimizing this tomorrow, we'd have to run spec again and analyze it.  
>  We also really need to understand what optimizations need to be happening, not just randomly implement stuff in various passes because it increases SPEC


Hi Daniel,

I didn't see this as a "new optimisation that needs doing", just as an "omitted analysis that got finally added", and obviously, if you have AA, then alias analysis will be done and the case where that matters will be better.

IIUC, the test is just to make sure it doesn't get removed or changed in the future.

The comment about SPEC improvement, from my POV was irrelevant, given that this is an obvious win.

Unless I'm missing something obvious here, of course... :)

--renato


https://reviews.llvm.org/D30352