[PATCH] D29940: Allow use of spaces in Bugpoint ‘--compile-command’ argument

[Matthias Braun via Phabricator via llvm-commits]

MatzeB accepted this revision.
MatzeB added a comment.
This revision is now accepted and ready to land.

LGTM (no further review necessary for the remaining nitpick)



================
Comment at: ToolRunner.cpp:386
+  for (std::size_t Pos = 0u; Pos <= CommandLine.size(); ++Pos) {
+    if ('\\' == CommandLine[Pos]) {
+      if (Pos + 1 < CommandLine.size())
----------------
You may consider factoring out `CommandLine[Pos]` (as in `char C = CommandLine[Pos];` in the first line of the loop).


https://reviews.llvm.org/D29940