[PATCH] D30448: [DebugInfo] Show implicit_const values when dumping .debug_info section

[Victor Leschuk via llvm-commits]

On 02/28/2017 08:58 PM, David Blaikie wrote:
>
>
> On Tue, Feb 28, 2017 at 9:55 AM Victor Leschuk 
> <vleschuk at accesssoftek.com <mailto:vleschuk at accesssoftek.com>> wrote:
>
>     Maybe we should just add one more constructor for DWARFFormValue
>     which would set both Form and Value fields?
>
> That's /sort/ of what I'm suggesting, but providing a wrapper around 
> that data so the code here doesn't have to have explicit support for 
> values. It should be part of some 'form' abstraction/concept (that 
> carries both the form enumerator and any other data is needed - the 
> value).
I understand, but isn't DWARFFormValue already such a wrapper itself? It 
holds enumerator and a union field which hides the actual data 
representation. We just need to widen it's API in order to be able 
construct it with one call, not construct+initialize.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170228/8b25c4b7/attachment.html>