[PATCH] D30364: AArch64 : Add PreferCSEL feature for Exynos-M3.

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 28 06:49:03 PST 2017


rengolin added a comment.

In https://reviews.llvm.org/D30364#687974, @flyingforyou wrote:

> This patch was inspired by below ARM's code. May I change this? What is your suggestion for the name "Don't use".?


I thought as much, but that's a bad design and shouldn't repeat.

We had similar discussions with the Samsung and Code Aurora people and we managed to work around all the issues. Shouldn't be too hard to do the same here.

We have actually removed a lot of code that was doing similar things, so I think we should add it back again.

cheers,
-renato


https://reviews.llvm.org/D30364





More information about the llvm-commits mailing list