[polly] r296348 - [DeLICM] Add nomap regressions tests. NFC.

Tobias Grosser via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 28 05:15:21 PST 2017


On Tue, Feb 28, 2017, at 07:58 AM, Tobias Grosser via llvm-commits
wrote:
> On Mon, Feb 27, 2017, at 04:53 PM, Michael Kruse via llvm-commits wrote:
> > Author: meinersbur
> > Date: Mon Feb 27 09:53:18 2017
> > New Revision: 296348
> > 
> > URL: http://llvm.org/viewvc/llvm-project?rev=296348&view=rev
> > Log:
> > [DeLICM] Add nomap regressions tests. NFC.
> > 
> > These verify that some scalars are not mapped because it would be
> > incorrect to do so.
> > 
> > For these check we verify that no transformation has been executed from
> > output of the pass's '-analyze'. Adding optimization remarks is not
> > useful
> > as it would result in too many messages, even repeated ones. I avoided
> > checking the '-debug-only=polly-delicm' output which is an antipattern.
> 
> Very cool. This very nicely documents the situations in which delicm is
> incorrect! Thank you!

We also just got the new coverage information. DeLICM is now really well
covered! (Some parts are still missing, but your testing effort pushed
the coverage a lot further! Cool.

Best,
Tobias


More information about the llvm-commits mailing list