[PATCH] D30053: Add function importing info from samplepgo profile to the module summary.

Dehao Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 27 13:55:43 PST 2017


danielcdh added inline comments.


================
Comment at: lib/IR/Function.cpp:1305
+  MDNode *MD = getMetadata(LLVMContext::MD_prof);
+  if (MD && MD->getOperand(0))
+    if (MDString *MDS = dyn_cast<MDString>(MD->getOperand(0)))
----------------
tejohnson wrote:
> When would we have the metadata but not the operand?
Shouldn't happen, Removed the 2nd check.


https://reviews.llvm.org/D30053





More information about the llvm-commits mailing list