[PATCH] D29872: Do not legalize large add with addc/adde, introduce addcarry and do it with uaddo/addcarry

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 27 13:55:06 PST 2017


efriedma added inline comments.


================
Comment at: include/llvm/CodeGen/ISDOpcodes.h:236
+    /// a glue, which allows further optimisation.
+    ADDCARRY, SUBCARRY,
+
----------------
Please explicitly note that the carry input to SUBCARRY supposed to be the output of USUBO; the "carry" bit is defined differently on some architectures.


https://reviews.llvm.org/D29872





More information about the llvm-commits mailing list